Opened on 01/06/2015 at 01:17:53 PM
Closed on 01/15/2015 at 02:06:14 PM
#1757 closed change (fixed)
Integrate ensure_dependencies.py with the adblockpluschrome repository
| Reported by: | kzar | Assignee: | poz2k4444 |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.10-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | #1364, #1588 |
| Blocking: | #1800 | Platform: | Chrome |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by kzar)
Background
In #170 we introduced our custom dependency mechanism, it should be used by the adblockpluschrome repository.
What to change
- Add the ensure_dependencies.py script to the root of the adblockpluschrome repository.
- Migrate the contents of the .hgsub and .hgsubstate files to a dependencies file for use by the ensure_dependencies.py script. (See ticket #170 and the script itself for more information about the format. See the infrastructure repository for a working example.)
- Update build.py to execute the ensure_dependencies.py script as a subprocess before running tasks. (See this code review for an example of how to do it.)
Attachments (0)
Change History (15)
comment:1 Changed on 01/06/2015 at 01:23:06 PM by poz2k4444
- Blocked By 1364 added
comment:2 Changed on 01/06/2015 at 01:58:33 PM by sebastian
- Cc sebastian added
- Component changed from Unknown to Platform
- Priority changed from Unknown to P4
comment:3 Changed on 01/06/2015 at 03:10:55 PM by poz2k4444
- Blocked By 1588 added
comment:7 Changed on 01/06/2015 at 03:22:23 PM by poz2k4444
FYI: ensure_dependencies.py should be called as a script, here is a codereview with a LGTM with a working example as well.
comment:10 Changed on 01/06/2015 at 03:31:56 PM by kzar
- Description modified (diff)
comment:11 Changed on 01/06/2015 at 03:48:17 PM by kzar
- Description modified (diff)
comment:12 Changed on 01/06/2015 at 03:52:53 PM by sebastian
- Ready set
comment:13 Changed on 01/13/2015 at 05:07:41 PM by trev
- Blocking 1800 added
comment:14 Changed on 01/13/2015 at 05:15:09 PM by poz2k4444
- Review URL(s) modified (diff)
comment:15 Changed on 01/15/2015 at 02:06:14 PM by sebastian
- Milestone set to Adblock-Plus-1.8.10-for-Chrome-Opera-Safari
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
The description isn't clear, please improve it.
Replying to kzar:
As time of writing, we already use the latest version of the buildtools. Also what's the point of updating it, when removing .hgsub and .hgsubstate in the same step?
Nobody except the authors of ensure_dependencies.py would know what this means. Also it is slightly misleading, since .hgsub and .hgsubstate aren't supposed to be simply removed, but their content needs to be migrated to the dependencies file. Please phrase it like that and refer to documentation or examples of the required format.
This isn't accurate. Since ensure_dependencies.py is both, a Python module and executable script, you should specify how it is supposed to be called. Also when exactly is first? I suppose you mean before importing buildtools.build, to make sure that the correct buildtools version is used. Also it's not clear whether ensure_dependencies.py should be called from the buildtools repo or if there is supposed to be a copy in the current repository.