Opened on 09/15/2014 at 09:36:41 AM
Closed on 09/18/2014 at 09:26:14 PM
#1374 closed change (fixed)
Don't hardcode web handlers for multiplexer
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
http://codereview.adblockplus.org/5744805892063232/ |
Description
Background
We use multiplexer.fcgi to merge various web handlers in a single FCGI process. Currently, this process will always load all available handlers. This approach has the drawbacks that all handlers need to be loaded explicitly in the sitescripts.web module. It also means that using multiplexer.fcgi always requires installing all the dependencies required by the web handlers - e.g. quite a few servers have to install MySQLdb even though they don't really use it (only required for the reports handler).
What to change
Add a [multiplexer] section to sitescripts.ini with an option for each web handler that should be enabled.
Fixed:
https://hg.adblockplus.org/sitescripts/rev/ed110f24a2ca
https://hg.adblockplus.org/infrastructure/rev/16b95be3b07e