Opened on 03/11/2014 at 10:27:12 AM

Last modified on 02/22/2016 at 01:54:24 PM

#14 reopened change

Fix periodic subscription refresh or remove it from advanced settings

Reported by:	fhd	Assignee:
Priority:	P3	Milestone:
Module:	Adblock-Plus-for-Android	Keywords:
Cc:	rjeschke, sergz	Blocked By:
Blocking:		Platform:	Android
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):

Description (last modified by rjeschke)

Background

See #7.

What to change

Fix periodic subscription refresh or remove it from advanced settings.

This is about the fact that nothing you set in advanced options for subscription refresh has any effect on the refresh process (as everything is only controlled by libadblockplus/adblockplus).

Change History (19)

comment:1 Changed on 03/11/2014 at 10:51:58 AM by philll

Blocking 7 added

comment:2 Changed on 03/11/2014 at 12:57:59 PM by philll

Keywords libadblockplus integration cleanup removed

comment:3 Changed on 03/11/2014 at 09:34:51 PM by trev

Component changed from Unknown to ABP-Android

comment:4 Changed on 03/12/2014 at 11:38:19 AM by philll

Owner set to rjeschke
Status changed from new to assigned

comment:5 Changed on 03/12/2014 at 04:44:44 PM by fhd

Description modified (diff)
Summary changed from [libadblockplus integration cleanup] Reimplement periodic subscription refresh or remove its configuration from advanced settings. to [libadblockplus integration cleanup] Fix periodic subscription refresh or remove it from advanced settings

comment:6 Changed on 03/12/2014 at 04:44:48 PM by fhd

Reporter changed from philll to fhd

comment:7 Changed on 03/12/2014 at 04:55:19 PM by fhd

Priority changed from Unknown to P3

comment:8 Changed on 03/12/2014 at 05:12:33 PM by fhd

Owner rjeschke deleted

comment:9 Changed on 03/12/2014 at 05:12:56 PM by fhd

Status changed from assigned to accepted

comment:10 Changed on 03/21/2014 at 09:11:02 AM by philll

Status changed from accepted to new

comment:11 Changed on 05/02/2014 at 09:26:13 AM by rjeschke

Blocking 7 removed
Ready unset
Summary changed from [libadblockplus integration cleanup] Fix periodic subscription refresh or remove it from advanced settings to Fix periodic subscription refresh or remove it from advanced settings

comment:12 Changed on 05/05/2014 at 11:12:23 PM by fhd

René, can you add some more info here if you know what this is about? Also, no need to mention #7 in the description anymore now that the connection is gone.

comment:13 Changed on 05/15/2014 at 02:59:31 PM by philll

Cc rjeschke added

@rjeschke:

comment:14 Changed on 10/08/2014 at 11:19:39 AM by rjeschke

Platform set to Android
Ready set

comment:15 Changed on 10/08/2014 at 11:21:04 AM by rjeschke

Description modified (diff)

comment:16 Changed on 05/19/2015 at 07:17:40 PM by agnieszka.domanska

I'll take that. If I may make a decision I will just remove it. If you would prefer me to try to fix it first - what should be the meaning of "periodically" (how often should it refresh)?

comment:17 Changed on 05/19/2015 at 08:11:49 PM by agnieszka.domanska

I removed periodic subscription refresh from Advance Preferences. Pull request on github.

comment:18 Changed on 06/18/2015 at 02:28:14 PM by fhd

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:19 Changed on 02/22/2016 at 01:54:24 PM by sergz

Cc sergz added
Review URL(s) modified (diff)
Status changed from reviewing to reopened
Tester set to Unknown

The PR is closed, so I have removed it from Review URL field and changed the state of the issue.

If we want to have the ability to configure the update interval we need to firstly make changes in adblockpluscore, see #3677.

Context Navigation