[meta] libadblockplus integration cleanup

[fhd]

Background

The libadblockplus integration review was huge, and we decided to create follow-ups for anything non-critical.

What to change

Fix all these issues:

Ticket	Status	Resolution	Summary	Owner
#8	closed	fixed	[libadblockplus integration cleanup] Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild	fhd
#9	closed	fixed	[libadblockplus integration cleanup] Catch exceptions consistently	fhd
#10	closed	fixed	[libadblockplus integration cleanup] Consider the encoding	fhd
#11	closed	fixed	[libadblockplus integration cleanup] Don't lower-case the header value	fhd
#12	closed	fixed	[libadblockplus integration cleanup] Translate Java network errors properly	fhd
#15	closed	fixed	[libadblockplus integration cleanup] Store the exception message in JavaException rather than extracting it when an exception occurs	fhd
#17	closed	fixed	[libadblockplus integration cleanup] Don't hard code the JNI version
#18	closed	incomplete	[libadblockplus integration cleanup] Use shared pointers for the platform-specific implementations
#19	closed	fixed	[libadblockplus integration cleanup] Initialise path variable closer to its use	fhd
#20	closed	fixed	[libadblockplus integration cleanup] Don't use std::bind for UpdateAvailableCallback, it's redundant
#21	closed	fixed	[libadblockplus integration cleanup] Don't manually clean up callbacks
#22	closed	fixed	[libadblockplus integration cleanup] Don't call IsListed(), it's redundant
#23	closed	fixed	[libadblockplus integration cleanup] Rename "actualize" function
#24	closed	fixed	[libadblockplus integration cleanup] Use Matcher.find() instead of Matcher.matches()
#25	closed	fixed	[libadblockplus integration cleanup] Rename globalJvm parameter
#26	closed	fixed	[libadblockplus integration cleanup] Reduce exception handling code duplication
#27	closed	fixed	[libadblockplus integration cleanup] Remove unnecessary DeleteLocalRef()
#28	closed	fixed	[libadblockplus integration cleanup] Simplify counting loop
#29	closed	fixed	[libadblockplus integration cleanup] Create RAII wrapper for JNIEnv
#30	closed	fixed	[libadblockplus integration cleanup] Remove unused variable
#31	closed	fixed	[libadblockplus integration cleanup] Move GetString to the JString helper class
#32	closed	fixed	[libadblockplus integration cleanup] Clean up build files	rjeschke
#33	closed	fixed	[libadblockplus integration cleanup] Use a smart pointer for the filter engine
#34	closed	fixed	[libadblockplus integration cleanup] Remove misleading const
#35	closed	incomplete	[libadblockplus integration cleanup] abpEngine.cpp needs various things cleaned up	rjeschke
#36	closed	fixed	[libadblockplus integration cleanup] Name source files consistently with libadblockplus (upper camel case)	rjeschke
#37	closed	fixed	[libadblockplus integration cleanup] Refactor JNI method registration to use 'registerNatives'
#38	closed	fixed	[libadblockplus integration cleanup] Refactor away global variable declarations in ApbEngine.cpp
#39	closed	fixed	[libadblockplus integration cleanup] Remove unused Java class files
#282	closed	fixed	[libadblockplus integration cleanup] Use Utils.getDocLink() instead of duplicating the functionality

[philll]

The assigned state will be dropped by #403

[philll]

@rjeschke: The issue looks pretty complete to me. If you agree, please set it to "ready"

[rjeschke]

@philll: Let me have a look at the last 4 open issues (today/tomorrow), then we can close this issue.

[johnson83]

spam

[slotslotonline]

spam