Opened on 03/13/2014 at 02:40:54 PM

Closed on 04/16/2014 at 10:17:41 AM

#143 closed change (fixed)

Use chrome.runtime.reload() to reload Adblock Plus in Chrome development environment

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5732684932317184

Description

Background

Currently the chromeDevenvPoller__.js script responsible for reloading extension in development environment when it updates doesn't do so cleanly.

What to change

buildtools/chromeDevenvPoller__.js.tmpl can use chrome.runtime.reload() instead of reloading the background page.

Attachments (0)

Change History (4)

comment:1 Changed on 03/13/2014 at 02:41:28 PM by trev

  • Summary changed from Use chrome.runtime.reload() to reload Adblock Plus in Chrome developer environment to Use chrome.runtime.reload() to reload Adblock Plus in Chrome development environment

comment:2 Changed on 04/16/2014 at 10:02:23 AM by trev

  • Owner set to trev
  • Ready set
  • Status changed from new to assigned

comment:3 Changed on 04/16/2014 at 10:03:59 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:4 Changed on 04/16/2014 at 10:17:41 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.