Opened on 03/13/2014 at 02:35:18 PM
Closed on 04/20/2018 at 02:01:11 PM
#142 closed change (invalid)
Ad counter: A different text should be shared if the ad count is zero
| Reported by: | greiner | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | User-Interface | Keywords: | goodfirstbug |
| Cc: | ileonelperea | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Currently, if the user shares his ad count when the count is zero the message "I blocked 0 ads and trackers thanks to Adblock Plus" is shared which doesn't make all that much sense.
What to change
A different message should be shared in that scenario, maybe: "I am blocking ads and trackers thanks to Adblock Plus."
Attachments (3)
Change History (15)
comment:1 Changed on 03/13/2014 at 02:36:17 PM by trev
- Keywords goodfirstbug added
comment:2 Changed on 04/23/2014 at 06:51:32 PM by ileonelperea
Changed on 04/23/2014 at 06:52:00 PM by ileonelperea
comment:3 Changed on 04/24/2014 at 02:39:25 PM by greiner
- Cc ileonelperea added
- Ready unset
- Status changed from new to reviewing
comment:4 follow-up: ↓ 5 Changed on 04/24/2014 at 03:06:10 PM by greiner
Thanks for the contribution. Please make the following changes:
- The message description should indicate that this message is only shared when nothing has been blocked.
- You only need to change the message for en_US because the rest will be done through CrowdIn.
- Add a space between if and (.
- You don't need to pass blockedCount for this message because it doesn't use the number.
comment:5 in reply to: ↑ 4 Changed on 04/25/2014 at 09:36:10 AM by thetonymaster
I've made the requested changes. It's the file patch.diff
comment:6 Changed on 04/25/2014 at 05:55:00 PM by ileonelperea
I add the path with others languages
Changed on 04/25/2014 at 05:57:40 PM by ileonelperea
many languages
comment:7 Changed on 04/28/2014 at 09:35:13 AM by greiner
Regarding translations: There's no need to submit translations at this stage. Also don't use Google Translate for translations.
One more thing: There's no need to replace the whole message description because translators still need to know when and where this message will appear. So please change it to the following:
"This message will be posted to social networks if the user decides to share the stats and nothing has been blocked yet."
Changed on 04/29/2014 at 03:34:44 PM by thetonymaster
Patch with required description and without languajes.
comment:8 Changed on 04/29/2014 at 03:35:35 PM by thetonymaster
I've uploaded the patch with that string, it doesn't have another translations.
comment:9 Changed on 04/30/2014 at 01:29:58 PM by philll
We might want to combine this issue with #349
comment:10 Changed on 04/30/2014 at 02:05:44 PM by greiner
@philll No, those are two separate issues about two separate texts. This one is about the text that is being shared while #349 is about the text that encourages users to share.
comment:11 Changed on 05/19/2014 at 03:28:09 PM by philll
@greiner: please add sufficient information to this issue once you accepted a patch and set it to "ready" such that testers can actually verify this being according to the requirements.
comment:12 Changed on 04/20/2018 at 02:01:11 PM by greiner
- Platform set to Unknown / Cross platform
- Resolution set to invalid
- Status changed from reviewing to closed
- Tester set to Unknown
This ticket is no longer valid because the share buttons have been removed in #5613.
Hi my name is Leonel, I am new here and I am trying to contribute to your project. I made a diff patch. Please review it so we can make it better.
I've created the string in english and spanish.