Opened on 09/26/2014 at 08:37:11 AM
Closed on 08/29/2019 at 05:48:47 PM
#1446 closed defect (rejected)
Web page's "click" event handler interferes with "Block Element"
| Reported by: | passbrains | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-70
Environment
Windows + Vista 64bit + Opera + English
ABP version Adblock Plus Version 1.8.5.1221
How to reproduce
- Got to http://www.google.com
- Enter "Purifier" into the search field
- Open the "More" dropdown
- Click the ABP icon and choose "Block Element"
- Click on the "Books" item
Observed behaviour
The "Books" menu item is highlighted in yellow, but when clicked the "Block Element" dialog doesn't open, but the page navigates to the book search.
Expected behaviour
The page's event handler shouldn't be triggered, that no navigation happens, but the "Block Element" dialog shows up. This can be achieved by positioning an invisible click trap element over the highlighted element.
Attachments (1)
Change History (5)
Changed on 09/26/2014 at 08:37:14 AM by passbrains
comment:1 Changed on 09/26/2014 at 09:04:19 AM by sebastian
- Cc sebastian added
- Component changed from Unknown to Platform
- Description modified (diff)
- Platform changed from Opera to Unknown
- Priority changed from Unknown to P3
- Ready set
- Summary changed from Block element behavior is inappropriate on list items to Web page's "click" event handler interferes with "Block Element"
comment:2 Changed on 09/26/2014 at 09:34:11 AM by sebastian
comment:3 Changed on 09/21/2017 at 01:44:39 AM by sebastian
- Priority changed from P3 to P4
- Tester set to Unknown
I can no longer reproduce this issue as described. However, this is most likely just because the Google website changed a lot in 3 years. But the document cancelling event listeners, the "Block element" dialog relies on those events, might still cause side effects.
comment:4 Changed on 08/29/2019 at 05:48:47 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Also see #1373.