Opened on 03/13/2014 at 05:01:00 PM

Closed on 04/22/2014 at 07:20:12 PM

#147 closed change (fixed)

[Typed objects] Implement object types

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #145 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4827963358969856/

Description (last modified by trev)

Background

See #145.

What to change

new ObjectType() should be used to create a new type. First parameter defines type properties and methods, e.g. {x: uint8, y: float32, m: function(){}}. Second parameter defines type metadata, for now only the constructor property is important. The returned type is a function, it can be called to create an object instance. Any parameters will be passed to the constructor function.

Attachments (0)

Change History (3)

comment:1 Changed on 03/13/2014 at 05:01:13 PM by trev

  • Status changed from new to assigned

comment:2 Changed on 04/17/2014 at 08:41:48 PM by trev

  • Description modified (diff)
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:3 Changed on 04/22/2014 at 07:20:12 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockpluscore/rev/3697c9f2bdd0

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.