Opened on 10/20/2014 at 08:53:12 AM
Closed on 11/21/2016 at 11:13:29 AM
#1486 closed change (fixed)
Move Passthru APP to a dedicated directory
| Reported by: | fhd | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr | Blocked By: | |
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29330683/ |
||
Description
Background
We currently have the source files of Passthru APP under src/plugin, next to ours. We should move them to a dedicated directory to make it more obvious that this is third party code, and to make it easier to update.
What to change
Move the Passthru APP source files to a dedicated directory. It might make sense to update them (e.g. to this version on GitHub) while we're at it. License files etc. should be included as well.
We don't have any other third party code in ABP for IE, so it's not obvious where to put this. I suggest /third_party/passthruapp (third_party being next to src and test, as in libadblockplus).
Attachments (0)
Change History (8)
comment:1 Changed on 10/20/2014 at 08:53:31 AM by fhd
- Platform changed from Unknown to Internet Explorer
comment:2 Changed on 10/20/2014 at 08:54:02 AM by fhd
- Cc oleksandr added
comment:3 Changed on 10/20/2014 at 08:54:14 AM by fhd
- Blocked By 1484 added
comment:4 Changed on 10/20/2014 at 09:57:46 AM by oleksandr
- Ready set
comment:5 Changed on 11/25/2015 at 04:04:50 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
- Tester set to Unknown
comment:6 Changed on 12/01/2015 at 12:16:13 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
comment:7 Changed on 11/21/2016 at 10:46:04 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Oleksandr, please have a look and mark as ready if you agree.