Opened on 10/31/2014 at 02:45:33 PM
Closed on 01/13/2015 at 02:18:49 PM
#1518 closed change (fixed)
Get rid of deprecated code using webkitNotifications
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.10-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | goodfirstbug |
| Cc: | saroyanm | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
When we initially implemented the anti-adblock notification (#174), we used webkitNotifications as fallback, when rich notifications for extensions aren't available.
But webkitNotifications.createHTMLNotification() has been dropped in Chrome 28, and older versions of Chrome aren't supported by Adblock Plus anymore. Therefore this code can be removed now.
Also webkitNotifications.createNotification() is deprecated, and new Notification() should be used instead.
What to change
- Remove code using webkitNotifications.createHTMLNotification().
- Adapt code using webkitNotifications.createNotification() to use new Notification() instead.
Attachments (0)
Change History (5)
comment:1 Changed on 01/07/2015 at 04:03:00 PM by sebastian
- Description modified (diff)
- Owner set to sebastian
- Summary changed from Remove fallback code using createHTMLNotification to Get rid of deprecated code using webkitNotifications
comment:2 Changed on 01/07/2015 at 04:04:18 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 01/13/2015 at 02:18:49 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/8c55c601fa60