Opened on 03/19/2014 at 02:49:55 PM
Closed on 03/25/2014 at 06:59:30 AM
Last modified on 03/25/2014 at 07:10:10 AM
#174 closed change (fixed)
Port anti-adblock notification to Chrome, Opera and Safari
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | fhd, trev | Blocked By: | #196 |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5749582424178688/ |
||
Description (last modified by greiner)
Background
We introduced the anti-adblock notification in Firefox for showing a new type of notification to users visiting websites which show anti-adblock warning messages.
What to change
Reuse the core code and implement the new "question"-type notification for Chrome, Opera and Safari.
Attachments (0)
Change History (3)
comment:1 Changed on 03/19/2014 at 04:26:22 PM by greiner
- Description modified (diff)
- Summary changed from Port over anti-adblock notification to Port anti-adblock notification to Chrome, Opera and Safari
comment:2 Changed on 03/25/2014 at 06:59:30 AM by trev
- Cc trev added
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 03/25/2014 at 07:10:10 AM by trev
- Blocked By 196 added
Note: See
TracTickets for help on using
tickets.
Seeing that both changes already landed, I think that this can be resolved as fixed.
https://hg.adblockplus.org/adblockplus/rev/41296853991b
https://hg.adblockplus.org/adblockpluschrome/rev/fa4e83869b3c