Opened on 11/05/2014 at 04:40:52 PM
Closed on 01/30/2015 at 04:09:55 PM
Last modified on 02/19/2015 at 07:42:01 AM
#1529 closed change (fixed)
Support case-insensitive header comparison in PluginWbPassThrough.cpp
| Reported by: | oleksandr | Assignee: | Mailkov |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.4 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | goodfirstbug |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
Taken from: http://codereview.adblockplus.org/4974480757620736/diff/5630721452408832/src/plugin/PluginWbPassThrough.cpp
Currently when extracting header in PluginWbPassThrough.cpp our code is case-sensitive. It's fine for now, but would be safer to have case-insensitive code.
What to change
Change the header extraction code to case-insensitive one.
Attachments (0)
Change History (8)
comment:1 Changed on 01/08/2015 at 09:43:16 PM by Mailkov
comment:3 Changed on 01/14/2015 at 10:10:13 AM by Mailkov
Pull request https://github.com/adblockplus/adblockplusie/pull/6
comment:4 Changed on 01/19/2015 at 09:04:16 AM by Mailkov
Can you review this issue? Thanks
comment:5 Changed on 01/23/2015 at 07:23:48 AM by Mailkov
Change pull request https://github.com/adblockplus/adblockplusie/pull/7
Can you review this issue? Thanks !!!
comment:6 Changed on 01/30/2015 at 02:51:10 PM by Mailkov
New pull request https://github.com/adblockplus/adblockplusie/pull/8
Can you merge this? Thanks !!!
comment:7 Changed on 01/30/2015 at 04:09:55 PM by oleksandr
- Resolution set to fixed
- Status changed from new to closed
comment:8 Changed on 02/19/2015 at 07:42:01 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
I would like to work on this change.