Opened on 11/05/2014 at 05:06:35 PM

Closed on 11/19/2014 at 11:41:56 AM

Last modified on 12/12/2014 at 09:33:03 AM

#1530 closed change (fixed)

Improve detecting of subrequest issued by flash addon

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5506777797885952/

Description

Background

Now there is a heuristic based on flags from bind info (see PluginWbPassThrough.cpp IsFlashRequest) but flash plugin adds x-flash-version: <command separated version> header into pszAdditionalHeaders. The heuristic is still good for other cases but it would be more reliable to test the existence of that header as well.

Attachments (0)

Change History (5)

comment:1 Changed on 11/11/2014 at 01:36:32 PM by oleksandr

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 11/11/2014 at 01:42:42 PM by sergz

  • Owner set to sergz

comment:3 Changed on 11/12/2014 at 09:47:40 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 11/19/2014 at 11:41:56 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 12/12/2014 at 09:33:03 AM by fhd

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.3

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.