Opened on 11/06/2014 at 12:20:06 PM

Closed on 11/17/2014 at 04:01:40 PM

Last modified on 02/23/2015 at 01:12:36 PM

#1539 closed defect (fixed)

Remove static Context variable

Reported by: rjeschke Assignee: rjeschke
Priority: P2 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5606010064470016/

Description

The AboutDialog uses a static Context variable which gets initialized on construction. This is not necessary and should be replaced by the proper way, i.e. calling getContext() when needed.

Attachments (0)

Change History (3)

comment:1 Changed on 11/06/2014 at 12:21:36 PM by rjeschke

  • Owner set to rjeschke
  • Review URL(s) modified (diff)

comment:2 Changed on 11/17/2014 at 04:01:40 PM by rjeschke

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed on 02/23/2015 at 01:12:36 PM by rjeschke

  • Milestone set to Adblock-Plus-for-Android-1.3

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from rjeschke.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.