Opened on 11/06/2014 at 01:05:40 PM
Closed on 11/24/2014 at 05:10:14 PM
Last modified on 02/23/2015 at 01:12:08 PM
#1540 closed defect (fixed)
Utility method for loading text is at the wrong location
| Reported by: | rjeschke | Assignee: | rjeschke |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Android-1.3 |
| Module: | Adblock-Plus-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
There's a method called appendRawTextFile which is currently declared in class AdblockPlus but only used in AboutDialog and ProxyConfigurationActivity.
The correct location for this method should be Utils, and while we're on it we could directly close the resources correctly.
Attachments (0)
Change History (5)
comment:2 Changed on 11/24/2014 at 05:10:14 PM by rjeschke
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 11/25/2014 at 09:03:33 AM by philll
comment:4 Changed on 11/25/2014 at 11:00:17 AM by rjeschke
It could be tested if long texts in the app (like in the about dialogue) still appear correctly.
comment:5 Changed on 02/23/2015 at 01:12:08 PM by rjeschke
- Milestone set to Adblock-Plus-for-Android-1.3
Note: See
TracTickets for help on using
tickets.
What could possibly be tested here?