Opened on 11/07/2014 at 02:40:04 PM
Closed on 12/15/2014 at 12:15:44 PM
#1553 closed change (fixed)
Adblock Plus for Yandex Browser
Reported by: | simona | Assignee: | saroyanm |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Websites | Keywords: | growth |
Cc: | saroyanm, sergz, sven, greiner, sebastian, trev | Blocked By: | |
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
http://codereview.adblockplus.org/5253207810899968/ |
Description (last modified by trev)
Background
Adblock Plus for Chrome is compatible with Yandex Browser (24M of potential users).
What to change
- Create a new landing page for "Yandex Browser" users similar to the one for Google Chrome users.
When Yandex Browser users are identified on adblockplus.org, show the contents of the new page with the following URL: https://adblockplus.org/[..]/yandex-browser
The page should be identical with the landing pages for the Chrome version with the following changes:
- Replace the green button's label in EN "Install for Chrome" with "Install for Yandex Browser", in RU with "Установить для Яндекс.Браузера"
- Add the Yandex Browser icon (following the functionality as currently implemented to switch between the colored and the shadowed versions) as shown in the following attachments:
- In case Yandex Browser users opened other platforms landing page, change the notification sentence accordingly:
- EN: "It seems that you are using Yandex Browser. Go to Adblock Plus for Yandex Browser."
- RU: "Похоже, что Вы используете Яндекс.Браузер. Перейти к Adblock Plus для Яндекс.Браузера."
- The currently implemented link shall be changed to the url of the Yandex Browser's landing page.
- Change the "Learn more" section as follows:
EN:
Ad Blocker for Yandex Browser
Adblock Plus is the most advanced adblocker for Yandex Browser. Are you fed up with advertisers infringing on your browsing experience? Simply install the extension and all annoying ads will be automatically blocked from the internet. Blinking banners, popups, video commercials on YouTube, Facebook and Vkontakte ads: The Yandex Browser Adblock Plus extension will automatically remove any unwanted ad from every website you visit. Want more? You can easily activate additional privacy and security features such as tracking and malware protection.
Installing the Yandex Browser Adblock Plus add-on to your browser only takes a few seconds. Simply click the "Install for Yandex Browser" button above and confirm the installation by clicking the "Add" button. Please note: Yandex Browser displays a warning that Adblock Plus can access the data on any website you visit. This is a standard warning for Yandex Browser extensions running on every tab. We promise to never collect any data about you.
The add-on is developed by the open source community and free to use for everybody. With more than 50 million users, it is one of the most popular extensions ever.
RU:
Adblock Plus для Яндекс.Браузера
Adblock Plus является самым развитым блокировщиком рекламы для Яндекс.Браузера (Yandex Browser). Вам надоела реклама, портящая все сайты? Просто установите наше дополнение, и вся назойливая реклама в интернете будет автоматически заблокирована. Мигающие баннеры, всплывающие окна, видео реклама, реклама в социальных сетях, таких как Вконтакте, Одноклассники, Facebook и других - Adblock Plus для Яндекс.Браузера запросто удалит любую надоедливую рекламу со всех посещаемых вами сайтов. Хотите больше? Вы можете включить дополнительные функции, защищающие вашу безопасность в интернете.
Установка Adblock Plus занимает всего пару секунд. Просто нажмите на кнопку “Установить для Яндекс.Браузера” и подтвердите желание, нажав “Добавить”. Пожалуйста, учтите, что Яндекс.Браузер отображает сообщение, что Adblock Plus может получить доступ к вашим данным на посещаемых вами сайтах. Это стандартное предупреждение для браузерных расширений, работающих на всех вкладках. Мы обещаем никогда не собирать никакую информацию о Вас и Ваших данных.
Дополнение разработано и поддерживается открытым сообществом, и является полностью бесплатным для всех. Имея более 50 миллионов пользователей, Adblock Plus является одним из самых популярных расширений.
Implementation notes
On the technical side, /en/chrome, /en/opera and similar are all aliases of the page located under /en (index page). The page content doesn't change, but the class set on <div id="content"> determines which parts of it show up and which don't. In order for everything to work correctly several things need to be changed:
- index.css needs to change to hide/show the right content for Yandex Browser. This file is located in Anwiki repository.
- Index page contents needs to be adjusted (via Anwiki) to add parts specific to Yandex Browser.
- Server configuration (as well as the test configuration in the Anwiki repository) has to be adjusted to recognize Yandex Browser and handle /yandex-browser URL correctly.
It should be best to implement things in the order listed here to make sure the users don't see any incomplete functionality.
Attachments (6)
Change History (52)
comment:1 Changed on 11/07/2014 at 03:33:48 PM by saroyanm
- Cc saroyanm added
comment:2 Changed on 11/13/2014 at 02:08:46 PM by saroyanm
- Cc sergz added
- Owner set to saroyanm
comment:3 Changed on 11/13/2014 at 02:30:45 PM by saroyanm
- Cc sven added
comment:4 Changed on 11/13/2014 at 02:32:58 PM by saroyanm
- Cc greiner added
comment:5 Changed on 11/13/2014 at 02:33:33 PM by saroyanm
- Owner saroyanm deleted
comment:6 Changed on 11/13/2014 at 02:34:52 PM by saroyanm
@sergz, @simona Guys please provide text for "Learn more" section, when it's ready.
comment:7 Changed on 11/13/2014 at 02:38:26 PM by saroyanm
@Sven, also what you think about adding new icon right to Android ? I guess in that case we will need to shrink install button a little.
comment:9 follow-up: ↓ 10 Changed on 11/14/2014 at 01:55:28 PM by sebastian
I fear that when we begin to add an icon for every Chromium based browser (and maybe also Gecko based browsers in the future), our homepage will become cluttered rather quickly, and might confuse most of out website's visitors who never heard of those browsers.
So how about showing the Yandex icon (and similar) only to visitors using that browser and to visitors from countries where those browsers are popular?
comment:10 in reply to: ↑ 9 ; follow-up: ↓ 15 Changed on 11/14/2014 at 01:57:20 PM by saroyanm
Replying to sebastian:
So how about showing the Yandex icon (and similar) only to visitors using that browser and to visitors from countries where those browsers are popular?
Instead of Chrome Icon ?
comment:11 Changed on 11/14/2014 at 01:57:45 PM by simona
- Description modified (diff)
comment:12 Changed on 11/14/2014 at 02:02:48 PM by saroyanm
- Description modified (diff)
comment:13 Changed on 11/14/2014 at 02:03:35 PM by saroyanm
- Description modified (diff)
comment:14 follow-up: ↓ 17 Changed on 11/14/2014 at 02:12:12 PM by sergz
So how about showing the Yandex icon (and similar) only to visitors using that browser and to visitors from countries where those browsers are popular?
Instead of Chrome Icon ?
I don't think that hiding them for others is a good idea. I think the user's trust is in direct proportion to the number of supported platforms. So, I would suggest to put yandex browser, maxthon and maybe something else into special section of some "non-insanely-popular" platforms. And of course we can pick them and show immediately for users of these browsers.
comment:15 in reply to: ↑ 10 Changed on 11/14/2014 at 02:13:02 PM by sebastian
- Cc sebastian added
Replying to saroyanm:
Instead of Chrome Icon ?
I'd prefer to always show icons for the 6 large browsers/platforms, and the Yandex icon (an similar in the future) in addition, but only to users of those browsers, and maybe also to visitors from countries where those browsers are popular.
But yeah, when space is already a problem, replacing the Chrome icon for Yandex users would be an option. Anyway it's just a suggestion. I think Sven should have the final say here.
comment:16 Changed on 11/14/2014 at 02:18:05 PM by simona
I dont think that replacing is the solution ... Btw there is still a space for 2 more icons on the right side (that it keeps aligned with the header).
comment:17 in reply to: ↑ 14 Changed on 11/14/2014 at 02:20:09 PM by sebastian
Replying to sergz:
I don't think that hiding them for others is a good idea. I think the user's trust is in direct proportion to the number of supported platforms. So, I would suggest to put yandex browser, maxthon and maybe something else into special section of some "non-insanely-popular" platforms. And of course we can pick them and show immediately for users of these browsers.
I think it will rather confuse the average user, who never heard of those browsers. Also the main purpose of our homepage is to make people install Adblock Plus. And increasing the number of links, might turn down the conversion rate, in particular if those are irrelevant to most users.
comment:18 follow-up: ↓ 19 Changed on 11/14/2014 at 02:47:44 PM by sven
The idea for Yandex is that we show the text "Install for Yandex" in our download button (but only for Yandex users) without any additional icon. That's it.
comment:19 in reply to: ↑ 18 Changed on 11/14/2014 at 02:49:57 PM by saroyanm
Replying to sven:
The idea for Yandex is that we show the text "Install for Yandex" in our download button (but only for Yandex users) without any additional icon. That's it.
Should we highlight Chrome ?
comment:20 Changed on 11/14/2014 at 02:54:31 PM by sven
Since it's a chrome based browser it would make sense to highlight the Chrome icon, yes. If there are any concerns, let me know.
comment:21 Changed on 11/14/2014 at 03:30:45 PM by saroyanm
- Description modified (diff)
comment:22 follow-up: ↓ 24 Changed on 11/14/2014 at 04:02:57 PM by simona
comment:23 Changed on 11/15/2014 at 02:11:43 PM by saroyanm
- Priority changed from P2 to P1
comment:24 in reply to: ↑ 22 Changed on 11/17/2014 at 12:51:37 PM by trev
Replying to sven:
Since it's a chrome based browser it would make sense to highlight the Chrome icon, yes. If there are any concerns, let me know.
I strongly disagree. Yes, it is based on Chrome and we know that. However, users aren't necessarily aware of it. In particular, the latest Yandex Browser stopped linking to CWS so users have one less reason to assume that it is compatible with Chrome extensions.
IMHO we should have a new https://adblockplus.org/en/yandex-browser page, similarly to how we've done it for https://adblockplus.org/en/opera. The page content should be the same, merely a different button (Install in Yandex Browser). And we should have an icon for it of course.
Replying to simona:
FYI there is a press release in Russia going out on Wednesday (19.11.).
Why the urgency all the sudden?
comment:25 follow-up: ↓ 35 Changed on 11/17/2014 at 01:00:51 PM by saroyanm
- Priority changed from P1 to Unknown
Switching priority while still details are missing and we have some more questions to discuss.
comment:26 Changed on 11/17/2014 at 04:24:59 PM by sven
Since it's a chrome based browser it would make sense to highlight the Chrome icon, yes. If there are any concerns, let me know.
I strongly disagree. Yes, it is based on Chrome and we know that. However, users aren't necessarily aware of it. In particular, the latest Yandex Browser stopped linking to CWS so users have one less reason to assume that it is compatible with Chrome extensions.
Ok, let's finish that by using an icon, the "Install for Yandex" button and the https://adblockplus.org/en/yandex url.
comment:27 Changed on 11/17/2014 at 04:41:40 PM by philll
Please note that the product is called Yandex Browser, as Yandex only would refer to the company or search engine only. Please also note that its name is translated into Russian.
In general also please don't bury the description in the comments
comment:28 Changed on 11/17/2014 at 04:50:25 PM by sven
Ok, let's finish that by using an icon, the "Install for Yandex" button and the https://adblockplus.org/en/yandex url.
Sorry, my fault. @trev is right with the url. It should be https://adblockplus.org/en/yandex-browser.
Changed on 11/17/2014 at 04:51:48 PM by sven
Yandex icon active
Changed on 11/17/2014 at 04:52:00 PM by sven
Yandex icon inactive
comment:29 Changed on 11/17/2014 at 04:53:01 PM by sven
Everything for the implementation should be clear now.
comment:30 Changed on 11/17/2014 at 07:05:22 PM by trev
- Cc trev added
comment:31 Changed on 11/18/2014 at 08:55:51 AM by saroyanm
- Description modified (diff)
comment:32 Changed on 11/18/2014 at 08:59:26 AM by saroyanm
We are not using separate images for each browser icon, instead we need to update current sprite.
@Sven can you please provide updated sprite instead of images separately ?
Changed on 11/18/2014 at 09:00:26 AM by simona
Yandex Browser landing page: EN
Changed on 11/18/2014 at 09:09:34 AM by simona
Yandex Browser landing page: RU
comment:33 Changed on 11/18/2014 at 09:18:13 AM by simona
- Description modified (diff)
Changed on 11/18/2014 at 09:49:11 AM by sven
Sprite
comment:34 Changed on 11/18/2014 at 09:49:53 AM by sven
We are not using separate images for each browser icon, instead we need to update current sprite.
@Sven can you please provide updated sprite instead of images separately ?
I know. Usually Thomas did the sprite by himself. It's in the attachments now.
comment:35 in reply to: ↑ 25 ; follow-up: ↓ 36 Changed on 11/18/2014 at 10:08:37 AM by sebastian
Replying to saroyanm:
Switching priority while still details are missing and we have some more questions to discuss.
You use the "ready" flag to indicate that all details ar complete and final. This can be regardless of the priority. However, it clearly doesn't look like a P1, more like a P3 (since it's not a critical bug, neither is it on the roadmap).
comment:36 in reply to: ↑ 35 Changed on 11/18/2014 at 10:36:53 AM by saroyanm
- Priority changed from Unknown to P2
Replying to sebastian:
Replying to saroyanm:
Switching priority while still details are missing and we have some more questions to discuss.
You use the "ready" flag to indicate that all details ar complete and final. This can be regardless of the priority. However, it clearly doesn't look like a P1, more like a P3 (since it's not a critical bug, neither is it on the roadmap).
Okey, will update the priority, anyway while it's grows related ticket, will set priority to 2.
Thanks for information.
comment:37 Changed on 11/18/2014 at 10:41:56 AM by simona
- Description modified (diff)
- Priority changed from P2 to Unknown
comment:38 Changed on 11/18/2014 at 10:56:35 AM by saroyanm
- Priority changed from Unknown to P2
- Ready set
comment:39 Changed on 11/18/2014 at 10:58:50 AM by philll
- Description modified (diff)
comment:40 Changed on 11/18/2014 at 12:38:41 PM by trev
- Description modified (diff)
comment:41 Changed on 11/18/2014 at 01:54:47 PM by trev
- Description modified (diff)
comment:42 Changed on 11/26/2014 at 04:11:11 PM by simona
PR update: We would like to put out the press release in Russia 10.12. So the issue should be finalized 9.12.
This timing has been discussed with @saroyanm. If there are some troubles with it, please let me know that we can discuss it.
comment:43 Changed on 12/01/2014 at 04:14:00 PM by saroyanm
- Owner set to saroyanm
Changed on 12/02/2014 at 04:55:07 PM by saroyanm
@Sven what you think which placement looks better ? I think it's better to go with first one, having Yandex icon in the end.
comment:44 Changed on 12/03/2014 at 01:50:44 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:45 Changed on 12/14/2014 at 11:16:20 AM by fhd
- Review URL(s) modified (diff)
Added review for the servercontent changes.
comment:46 Changed on 12/15/2014 at 12:15:44 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
@Sven what you think would it be possible to add Yandex icon into sprite-index.png ?