Opened on 03/17/2014 at 11:50:16 AM
Closed on 03/20/2014 at 07:06:22 AM
Last modified on 04/13/2014 at 06:36:19 PM
#156 closed defect (fixed)
wrong icons parameter value in manifest.json for chrome
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | chrome, manifest, buildtools |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5406295150559232/ |
||
Description
How to reproduce
- build adblockpluschrome project using "./build.py -t chrome build"
...
Observed behaviour
icons parameter in manifest.json contains current object:
"icons": {
"128": "icons/abp-128.png",
"32": "icons/abp-32.png"
},
Expected behaviour
icons parameter in manifest.json should contain current object:
"icons": {
"128": "icons/abp-128.png",
"48": "icons/abp-48.png",
"16": "icons/abp-16.png"
},
according to chrome manifest documentation:
http://developer.chrome.com/extensions/manifest/icons
Attachments (0)
Change History (5)
comment:1 Changed on 03/17/2014 at 12:38:41 PM by saroyanm
- Status changed from new to assigned
comment:2 Changed on 03/18/2014 at 04:13:42 PM by saroyanm
- in_progress set to 0
- Ready unset
comment:3 Changed on 03/18/2014 at 05:23:43 PM by trev
- in_progress changed from 0 to 1
- Ready set
- Review URL(s) modified (diff)
- Status changed from assigned to reviewing
comment:4 Changed on 03/20/2014 at 07:06:22 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 04/13/2014 at 06:36:19 PM by trev
- Component changed from Build-and-Release-Tools to Platform
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See
TracTickets for help on using
tickets.
While the icons were moved to their appropriate directories in current review:
http://codereview.adblockplus.org/5406295150559232
icons/abp-48.png and icons/abp-16.png are no more available in icons directory.