ZeroDivisionError in sitescripts.stats.bin.pagegenerator

[trev]

Background

Our stats server was producing errors when generating pages lately:

  File "/opt/sitescripts/sitescripts/stats/template/fileStats.html", line 141, in top-level template code
    {{row(field.title, data[field.name].True, params, chart=False,
  File "/opt/sitescripts/sitescripts/stats/template/fileStats.html", line 93, in template
    <td align="right">{{(value.bandwidth / params.totalbandwidth * 100)|round(precision=1)}}%</td>
ZeroDivisionError: division by zero

Apparently, params.totalbandwidth is zero. We didn't consider that scenario when the script was created - there must be at least one hit, otherwise no statistics would exist for that file. Here that hit apparently produced zero bandwidth which is highly unusual but not impossible.

What to change

We should guard against division by zero here, similarly to how it is done elsewhere.

[trev]

Fixed: ​https://hg.adblockplus.org/sitescripts/rev/10ffba8a0b9c