Opened on 11/12/2014 at 09:56:46 PM
Closed on 01/10/2015 at 12:47:31 AM
#1561 closed change (fixed)
Move unit tests out of the browser's content area
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
Unit tests are currently running inside the browser's content area. This has the advantage of requiring no UI - entering a URL into the browser's location bar is enough. However, it also makes some things harder because the unit tests run on the wrong side of the security boundary. And the unit tests are completely broken with e10s because they run in the content process and not the chrome process now.
What to change
Create a XUL window for the unit tests so that no longer are in the browser's content are. Provide some minimal UI in the inline preferences to open that window.
Attachments (0)
Change History (4)
comment:1 Changed on 11/12/2014 at 10:43:45 PM by trev
comment:2 Changed on 11/14/2014 at 11:13:58 PM by trev
- Review URL(s) modified (diff)
Created review for work in progress, AFAICT only pop-up blocker tests still need to be fixed.
comment:3 Changed on 11/15/2014 at 11:56:04 PM by trev
- Status changed from new to reviewing
Review has been finalized.
comment:4 Changed on 01/10/2015 at 12:47:31 AM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
With my current changes most tests continue to work correctly. The pop-up blocking tests fail, that's pretty much expected as these expect to find a browser window. The unexpected part is content policy and element hiding tests failing, these simply don't get the load event for the frame for some reason (both with e10s and without).