Opened on 11/13/2014 at 09:14:15 AM
Closed on 11/21/2014 at 11:14:30 AM
Last modified on 12/12/2014 at 09:38:36 AM
#1562 closed change (fixed)
Improve detecting of XmlHttpRequest
Reported by: | sergz | Assignee: | sergz |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.3 |
Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
Cc: | oleksandr, arthur | Blocked By: | |
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by sergz)
Background
For requests issued with XMLHttpRequest IE sets header X-Requested-With: XMLHttpRequest. As well as we can classify requests with Origin header as xmlhttprequests.
What to change
Add the required functionality into PluginWbPassThrough.cpp
Attachments (0)
Change History (6)
comment:1 Changed on 11/13/2014 at 09:14:50 AM by sergz
- Status changed from new to reviewing
comment:3 Changed on 11/21/2014 at 10:54:41 AM by sergz
- Cc arthur added
comment:4 Changed on 11/21/2014 at 11:14:30 AM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
Committed "patch set 1"
comment:5 Changed on 12/12/2014 at 09:33:59 AM by fhd
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.3
comment:6 Changed on 12/12/2014 at 09:38:36 AM by fhd
- Priority changed from Unknown to P2
- Ready set
Posthumously setting priority and ready - P2 seems about appropriate here.
Note: See
TracTickets for help on using
tickets.
@oleksandr said:
I would drop detecting request with Origin header as XMLHttpRequest.
So, I would propose to drop it and see whether it's not enough with such approach.