Opened on 11/22/2014 at 03:26:59 PM
Closed on 11/25/2014 at 04:35:45 PM
#1594 closed defect (fixed)
Error in global page when bringing up contextmenu for blocked frame on Safari
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Safari 8
How to reproduce
- Go to Options -> General
- Disable "Show 'Block Element' right-click menu item"
- Load any website with blocked <iframe>elements, e.g. https://thepiratebay.se/search/Debian/0/99/0
- Right click on the blocked frame
Observed behaviour
There is no user visible affect, however if you inspect the extension's global page, you see an error being logged. That is because the content script's contextmenu event handler isn't called, and therefore event.userInfo is undefined in the global page.
Expected behaviour
The event handler in the global page should properly handle that case, without producing any errors.
Attachments (0)
Change History (2)
comment:1 Changed on 11/22/2014 at 03:28:55 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 11/25/2014 at 04:35:45 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/ed837c834c0b