Opened on 11/24/2014 at 11:48:08 AM
Closed on 01/08/2016 at 01:33:53 PM
Last modified on 12/15/2016 at 06:17:08 AM
#1596 closed defect (fixed)
Improper behavior when tried to Disable ABP for invalid pages.
| Reported by: | passbrains | Assignee: | Mailkov |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr, sergz | Blocked By: | |
| Blocking: | #3428 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Rraceanu | Verified working: | yes |
| Review URL(s): |
https://github.com/adblockplus/adblockplusie/pull/11 |
||
Description (last modified by oleksandr)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-69
Environment
Windows + 7 64bit + Internet Explorer 10 + English
ABP version 1.2.705.0
How to reproduce
Launch IE with ABP enabled.
Check the manage dialog on settings page.
On IE, click on new tab button to add another tab.Make sure new tab opens with by default page as 'about:blank'.
On the about:blank page, click on ABP icon and select option 'Disable on about:blank'.
Check the ABP icon, 'Disable on about:blank' button status and check manage dialog on settings page.
Observed behaviour
After selecting 'Disable on about:blank' button,
1.ABP icon does not get disabled and also looks distorted.
- 'Disable on about:blank' button does not get checked(enabled)
3.about:blank page get added in manage dialog on settings page.
[See attached video]
Expected behaviour
There should be consistency in behavior when user try to disable invalid pages.
1)Either Disable option should not work and page should not get added in manage dialog.
2)OR If it should work for any link, then ABP button and Disable option status should change accordingly.
Attachments (1)
Change History (16)
Changed on 11/24/2014 at 11:48:12 AM by passbrains
comment:1 Changed on 01/19/2015 at 12:24:58 PM by oleksandr
- Cc oleksandr added
- Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 01/19/2015 at 12:26:04 PM by oleksandr
- Priority changed from P3 to P4
comment:3 Changed on 02/02/2015 at 12:28:34 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
comment:4 Changed on 05/13/2015 at 09:55:24 AM by Mailkov
comment:5 Changed on 05/13/2015 at 11:22:56 AM by Mailkov
comment:6 Changed on 05/30/2015 at 10:57:22 AM by Mailkov
Can you assign it to me? So I will receive e-mail on this issue.
comment:7 Changed on 06/01/2015 at 08:35:57 AM by oleksandr
- Owner set to Mailkov
comment:8 Changed on 06/02/2015 at 12:28:29 PM by Mailkov
I have updated the pull request ... now the menuitem is hidden.
comment:9 Changed on 07/07/2015 at 11:32:03 PM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
- Tester set to Unknown
comment:10 Changed on 12/08/2015 at 08:20:57 PM by sergz
- Cc sergz added
comment:11 Changed on 12/17/2015 at 01:39:16 PM by eric@adblockplus.org
- Blocking 3428 added
comment:12 Changed on 01/08/2016 at 01:18:32 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
comment:13 Changed on 01/08/2016 at 01:33:53 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from reviewing to closed
comment:14 Changed on 11/08/2016 at 12:59:58 AM by rraceanu
- Tester changed from Unknown to Rraceanu
comment:15 Changed on 12/01/2016 at 01:18:53 AM by rraceanu
- Verified working set
Fixed implemented successfully ABP for IE 1.5.856, verified on Win 7, Win 8 and Win 10 IE 10 and 11. Text is greyed out and not functional when trying to add "invalid" pages as an exception.
I'd like to work on this.