Opened on 03/11/2014 at 10:29:34 AM

Closed on 05/05/2014 at 11:08:35 PM

#16 closed change (fixed)

[libadblockplus integration cleanup] Improve the JNI layer

Reported by: fhd Assignee: rjeschke
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: #7, #98 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6606493159784448/
​http://codereview.adblockplus.org/5697499218051072/
​http://codereview.adblockplus.org/5698450620416000/

Description (last modified by fhd)

Background

See #7.

What to change

We have multiple options. One way would be to create RAII wrappers for JNI objects (as discussed here: ​http://codereview.adblockplus.org/11172036/#msg3). Another option is to create thin JNI wrappers for the libadblockplus API and move most of the logic to Java.

We decided to go with the latter.

Attachments (0)

Change History (16)

comment:1 Changed on 03/11/2014 at 10:51:58 AM by philll

  • Blocking 7 added

comment:2 Changed on 03/11/2014 at 12:57:59 PM by philll

  • Keywords libadblockplus integration cleanup removed

comment:3 Changed on 03/11/2014 at 09:34:51 PM by trev

  • Component changed from Unknown to ABP-Android

comment:4 Changed on 03/12/2014 at 11:38:19 AM by philll

  • Owner set to rjeschke
  • Status changed from new to assigned

comment:5 Changed on 03/12/2014 at 04:55:19 PM by fhd

  • Priority changed from Unknown to P3

comment:6 Changed on 03/12/2014 at 05:03:18 PM by fhd

  • Description modified (diff)
  • Priority changed from P3 to Unknown
  • Summary changed from [libadblockplus integration cleanup] Create RAII wrappers for JNI objects to [libadblockplus integration cleanup] Deal with JNI better

comment:7 Changed on 03/12/2014 at 05:03:22 PM by fhd

  • Reporter changed from philll to fhd

comment:8 Changed on 03/12/2014 at 05:03:40 PM by fhd

  • Description modified (diff)

comment:9 Changed on 03/12/2014 at 05:04:15 PM by fhd

  • Summary changed from [libadblockplus integration cleanup] Deal with JNI better to [libadblockplus integration cleanup] Improve the JNI layer

comment:10 Changed on 03/12/2014 at 05:12:33 PM by fhd

  • Owner rjeschke deleted

comment:11 Changed on 03/12/2014 at 05:12:56 PM by fhd

  • Status changed from assigned to accepted

comment:12 Changed on 03/12/2014 at 05:14:44 PM by fhd

  • Priority changed from Unknown to P3

comment:13 Changed on 03/13/2014 at 12:57:33 AM by fhd

  • Owner set to rjeschke
  • Status changed from accepted to assigned

comment:14 Changed on 04/11/2014 at 04:13:23 PM by fhd

  • Blocking 98 added

comment:15 Changed on 04/30/2014 at 09:50:33 AM by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:16 Changed on 05/05/2014 at 11:08:35 PM by fhd

  • Milestone set to Adblock-Plus-for-Android-next
  • Ready set
  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from rjeschke.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.