Opened on 11/26/2014 at 10:47:07 AM

Closed on 11/26/2014 at 05:11:19 PM

#1610 closed defect (fixed)

"Block element" removes overlays while dialog still shows

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4923599135703040

Description

How to reproduce

  1. Go to ​http://9gag.com
  2. Click ABP icon
  3. Choose element
  4. Select an image

Observed behaviour

The dialog shows up, but the selected image isn't highlighted anymore. That is because the overlays (used to highlight images, frames, Flash, etc.) are removed when the dialog shows. Other elements are still highlighted until the dialog closes, however.

Expected behaviour

All elements should be highlighted until the dialog closes.

Attachments (0)

Change History (2)

comment:1 Changed on 11/26/2014 at 10:49:13 AM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/26/2014 at 05:11:19 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockpluschrome/rev/866a1cc31452

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.