Opened on 11/26/2014 at 11:27:17 AM

Closed on 12/08/2014 at 05:30:48 PM

#1611 closed defect (fixed)

Inconsistent behavior with "Block element" context menu item

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.8.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6236888415338496

Description (last modified by sebastian)

How to reproduce

  1. Go to ​http://adventagegroups.com/Index.aspx
  2. Wait till the image placeholder appears
  3. Right-click on image
  4. Choose "Block element"

Observed behaviour

The dialog doesn't show up. That is because since the image didn't load the context menu API doesn't provide a URL. However, when you use "Block element" form the popup UI the dialog shows up and suggests a filter based on the elements src attribute.

Expected behaviour

The behavior should be the same, regardless whether "Block Element" from the context menu or popup UI has been used, always generating all relevant filters.

Attachments (0)

Change History (4)

comment:1 Changed on 11/26/2014 at 11:28:16 AM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/27/2014 at 01:18:06 PM by sebastian

  • Description modified (diff)

Copied steps to reproduce from #1627, to point out that this issue can already be reproduced.

The intial issue description were about how multiple URLs considered with #1601, wouldn't be considered with "Block element" from the context menu, which is another scenario to reproduce the same issue.

comment:3 Changed on 11/27/2014 at 01:18:23 PM by sebastian

  • Description modified (diff)

comment:4 Changed on 12/08/2014 at 05:30:48 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.