Opened on 12/09/2014 at 05:59:23 PM
Closed on 12/11/2014 at 02:52:22 PM
#1678 closed change (fixed)
Add bidi support for Safari
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
With #1668 the text and layout direction on extension pages (like the options and first run page) will be set dependent on the UI language. However Safari doesn't have an i18n API. So we implemented Chrome's i18n API there, but without bidi support so far.
What to change
Add bidi support to the ext.i18n implementation for Safari, that ext.i18n.getMessage("@@bidi_dir") returns either "ltr" or "rtl" dependent on the UI language as it does on Chrome.
hints for testers
Make sure that the correct text and layout direction is used dependent on the language. Also see #1668.
Attachments (0)
Change History (3)
comment:1 Changed on 12/09/2014 at 06:00:58 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
- Summary changed from Support ext.i18n.getMessage("@@bidi_dir") on Safari to Add bidi support for Safari
comment:2 Changed on 12/10/2014 at 08:23:17 AM by sebastian
- Blocking 1668 removed
comment:3 Changed on 12/11/2014 at 02:52:22 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/03387c0159b5