Opened on 12/10/2014 at 11:07:57 AM
Closed on 01/06/2015 at 02:16:58 PM
Last modified on 02/19/2015 at 07:36:06 AM
#1681 closed change (fixed)
Incorrect usage of BString
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.4 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
In the file PluginClass.cpp the line BSTR urlToNavigate = BString(UserSettingsFileUrl()); is incorrect. urlToNavigate points to already released memory.
What to change
Use ATL::CComBSTR and we can get rid of BString.
Attachments (0)
Change History (5)
comment:1 Changed on 12/10/2014 at 11:36:27 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/10/2014 at 11:37:12 AM by sergz
- Owner set to sergz
comment:3 Changed on 01/05/2015 at 12:04:06 PM by oleksandr
- Platform changed from Unknown to Internet Explorer
- Priority changed from Unknown to P3
- Ready set
comment:4 Changed on 01/06/2015 at 02:16:58 PM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 02/19/2015 at 07:36:06 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See
TracTickets for help on using
tickets.
