Paypal contribution page tries to request some non-existing image

[philll]

How to reproduce

1. Go to ​https://adblockplus.org/en/donate
2. Check some donation amount's radio button
3. Click the donate button

Observed behaviour

The PayPal page opened tries to request the image ​https://eyeo.com/images/paypal_header.png which doesn't exist under this path.

Expected behaviour

The ABP logo should be displayed instead.

[philll]

I couldn't actually find where the image currently requested is defined, but handing over an image URL with some image_url or cpp_header_image parameter does the trick here, see also their ​"paypal documentation. We need to host some decently sized ABP logo first.

[trev]

It's quite certainly set in the PayPal account (​https://www.paypalobjects.com/webstatic/en_US/developer/docs/pdf/pp_merchantsetupadministrationguide.pdf, "Co-Branding the PayPal Checkout Pages" section). For Job's account only "Eyeo GmbH" appears as header, when using Till's account we get that image however. Overriding it is certainly a good idea, only question: what image should we use? Alternatively we could remove these settings from the account and just have a text header.

I'll attach paypal_header.png from the previous reincarnation of eyeo.com.

[trev]

Old PayPal header

[philll]

Well, that one​ looks certainly good. We can reuse it imo.

[trev]

It's actually pretty ugly, at least unless we also change the background color. But let's try this...

[trev]

I realized that passing in page_style: "paypal" makes PayPal forget anything defined in the account. Also, we should probably pass in cpp_payflow_color: "F6F4EF" to make sure that header image doesn't look out of place on a white background.

[trev]

Fixed: ​https://hg.adblockplus.org/www/rev/ee5db1e451e9