Opened on 03/18/2014 at 12:05:25 PM

Closed on 03/26/2014 at 10:49:49 AM

Last modified on 03/26/2014 at 01:36:46 PM

#171 closed defect (fixed)

[trac] setting issues to "codereview" status is possible for all users

Reported by: philll Assignee: philll
Priority: Unknown Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

http://codereview.adblockplus.org/5710953018556416/

Description

Environment

Trac instance at https://issues.adblockplus.org

How to reproduce

  1. Log in to the ABP Trac instance as normal user
  2. Open any existing Ticket, which does not have the depricated status "accepted"
  3. Expand the "Modify Ticket" section

Observed behaviour

The "codereview" radio button is displayed.

Expected behaviour

Except the already checked "leave as ..." option, no additional radio buttons should be available.

Attachments (0)

Change History (7)

comment:1 Changed on 03/18/2014 at 01:46:59 PM by philll

.

comment:2 Changed on 03/18/2014 at 03:25:15 PM by philll

  • Component changed from Unknown to Infrastructure

comment:3 Changed on 03/25/2014 at 04:56:26 PM by philll

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 03/26/2014 at 08:50:45 AM by philll

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 03/26/2014 at 10:07:09 AM by philll

  • Resolution fixed deleted
  • Status changed from closed to reopened

Setting the codereview status is still possible for users without the TICKET_MODIFY permission.

comment:6 Changed on 03/26/2014 at 10:49:49 AM by philll

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:7 Changed on 03/26/2014 at 01:36:46 PM by philll

  • Verified working set

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from philll.
 
Note: See TracTickets for help on using tickets.