Opened on 03/18/2014 at 05:17:04 PM
Closed on 03/28/2014 at 03:17:01 PM
Last modified on 04/13/2014 at 06:30:19 PM
#172 closed defect (fixed)
Don't make our icons web accessible
| Reported by: | trev | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | chrome |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
http://codereview.adblockplus.org/6098518317989888/ made icons/abp-128.png web accessible. This is bad because it makes Adblock Plus detectable in a trivial way. What's worse, it doesn't look like this is necessary - the icon actually used by notification.html is icons/abp-48.png, that's not the same icon.
This change needs to be reverted. If it turns out that a web-accessible icon is really needed, the extension should simply convert the icon into a data: URL.
Attachments (0)
Change History (6)
comment:1 in reply to: ↑ description Changed on 03/18/2014 at 05:25:37 PM by greiner
comment:2 Changed on 03/28/2014 at 11:59:15 AM by saroyanm
- Status changed from new to reviewing
comment:3 Changed on 03/28/2014 at 12:01:44 PM by saroyanm
Review Link:
http://codereview.adblockplus.org/5677191404716032/
comment:5 Changed on 03/28/2014 at 03:17:01 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 04/13/2014 at 06:30:19 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See
TracTickets for help on using
tickets.
Replying to trev:
icons/abp-128.png is used for webkitNotifications.createNotification and for chrome.notifications.create (see corresponding review).
That said, I still agree regarding the conversion to a data: URL.