Opened on 03/23/2014 at 02:28:13 PM

Closed on 03/27/2014 at 08:42:15 AM

Last modified on 04/13/2014 at 06:27:04 PM

#196 closed defect (fixed)

2.5.1.3785 doesn't automatically add filter lists after installing

Reported by: arthur Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.6-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: greiner Blocked By:
Blocking: #153, #174 Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6242239667765248/
http://codereview.adblockplus.org/6304089612746752

Description

Environment

  • Windows 8.1 Pro x64
  • Firefox 28.0
  • Adblock Plus dev build 2.5.1.3785
  • New Firefox browser profile

How to reproduce

  1. Create a new browser profile
  2. Install the latest dev build

Observed behaviour

Adblock Plus doesn't automatically add a suitable filter list.

Expected behaviour

It should add a suitable filter list automatically.

Attachments (0)

Change History (8)

comment:1 Changed on 03/25/2014 at 07:10:10 AM by trev

  • Blocking 174 added
  • Cc greiner added
  • in_progress changed from 0 to 1
  • Owner set to trev
  • Ready set
  • Status changed from new to assigned

Confirming, this is a regression from #174. In the Error Console I see:

ActiveFilter is not defined.

This is pointing to lib/antiadblockInit.js.

comment:2 Changed on 03/25/2014 at 07:12:34 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:3 Changed on 03/25/2014 at 10:29:20 AM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 03/26/2014 at 12:31:42 PM by trev

  • Milestone Adblock-Plus-for-Firefox-next deleted
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening, this doesn't seem to be completely fixed.

comment:5 Changed on 03/26/2014 at 12:55:54 PM by trev

  • Blocking 153 added
  • Status changed from reopened to assigned

Apparently, there is also a bug here introduced by #153.

comment:6 Changed on 03/26/2014 at 12:58:32 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:7 Changed on 03/27/2014 at 08:42:15 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 04/13/2014 at 06:27:04 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.