Opened on 12/30/2014 at 02:15:56 AM
Closed on 01/07/2015 at 02:38:02 PM
Last modified on 01/15/2015 at 06:56:10 PM
#1742 closed change (fixed)
Use "highlighted" property instead deprecated "selected" property when calling chrome.tabs.update()
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.10-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | #1820 | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Background
In order to focus an existing tab on Chrome we call chrome.tabs.update(id, {selected: true}). However, the selected property is deprecated, and highlighted should be used instead.
What to change
Adapt all chrome.tabs.update() calls to use the highlighted property instead the selected property.
Attachments (0)
Change History (3)
comment:1 Changed on 12/30/2014 at 02:17:12 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/07/2015 at 02:38:02 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 01/15/2015 at 06:56:10 PM by trev
- Blocked By 1820 added
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/e3bc8d8acbba