Opened on 12/29/2014 at 11:22:38 PM
Closed on 12/30/2014 at 02:03:39 AM
#1741 closed defect (duplicate)
"Block element" dialog doesn't work while first run page is open
| Reported by: | passbrains | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by sebastian)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-94
Environment
Windows + 8 64bit + Chrome + English
ABP version 1.8.8.1292
How to reproduce
- Install Adblock Plus, and wait for the first run page to show up
- Open another page (e.g. www.timesofindia.com)
- Click ABP icon and click on 'Block element'. Select an element to be blocked.
Observed behaviour
"Block element" dialog shows up, but the text field showing the suggested filters is empty.
Expected behaviour
Filter should be generated and suggested for the selected element.
Attachments (2)
Change History (4)
Changed on 12/29/2014 at 11:22:41 PM by passbrains
Changed on 12/29/2014 at 11:22:42 PM by passbrains
comment:1 Changed on 12/29/2014 at 11:28:46 PM by sebastian
- Cc sebastian added
- Component changed from Unknown to Platform
- Description modified (diff)
- Platform changed from Chrome to Unknown
- Priority changed from Unknown to P3
- Ready set
- Summary changed from Add Filters window always displays empty when click blocking element. to Add Filters dialog is broken after sharing on first run page
Note: See
TracTickets for help on using
tickets.
That is because the first run page responds to the clickhide-init message with an empty response, before the background page does. This is fixed when the default response is removed by #1708.