Opened on 01/08/2015 at 03:28:45 PM

Closed on 01/08/2015 at 04:58:12 PM

#1766 closed change (fixed)

Output directory for Safari development environment should be devenv/adblockplussafari.safariextension

Reported by: trev Assignee: sebastian
Priority: P4 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/4812956214755328

Description (last modified by sebastian)

Background

Currently the build.py -t safari devenv puts the files directly into the devenv folder. Safari won't load extensions from it however, it can only load unpacked extensions from folders with the .safariextension file extension.

What to change

Keep the same file structure when running build.py -t safari devenv as when generating builds, creating devenv/adblockplussafari.safariextension and putting the content of the extension there.

Attachments (0)

Change History (4)

comment:1 Changed on 01/08/2015 at 03:35:08 PM by sebastian

  • Keywords goodfirstbug added
  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed on 01/08/2015 at 04:41:31 PM by sebastian

  • Cc sebastian removed
  • Description modified (diff)
  • Owner set to sebastian
  • Summary changed from Output directory for Safari development environment should be devenv.safariextension to Output directory for Safari development environment should be devenv/adblockplussafari.safariextension

comment:3 Changed on 01/08/2015 at 04:44:50 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 01/08/2015 at 04:58:12 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.