Opened on 01/14/2015 at 09:20:52 PM

Closed on 01/15/2015 at 10:42:20 AM

#1808 closed defect (fixed)

ensure_dependencies.py generates wrong repository path for local roots

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5135047623442432/

Description

How to reproduce

  1. Use a file path as root for your repositories in dependencies file, e.g.: _root = hg:/foo/bar
  2. Add a dependency to dependencies file, e.g.: xyz = hg:12345
  3. Run ensure_dependencies.py

Observed behaviour

Cloning fails with the message "repository /foo/xyz not found" (repository path generated via urlparse.urljoin()).

Expected behaviour

Repository is cloned from /foo/bar/xyz (file path joining is used).

Attachments (0)

Change History (2)

comment:1 Changed on 01/14/2015 at 09:24:07 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/15/2015 at 10:42:20 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/buildtools/rev/2f744887c675

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.