Opened on 01/14/2015 at 09:28:01 PM

Closed on 01/15/2015 at 10:52:55 AM

#1809 closed change (fixed)

createNighlies determines hg root incorrectly

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5268597484027904/

Description

Background

createNightlies scripts overrides the root for Mercurial repositories when calling ensure_dependencies.py, this way local repositories are used. However, this is currently done via calling os.path.dirname(self.config.repository) which will return different results depending on whether the repository path ends with a slash.

What to change

Determine parent directory correctly.

Attachments (0)

Change History (2)

comment:1 Changed on 01/14/2015 at 09:32:42 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/15/2015 at 10:52:55 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/sitescripts/rev/bfef05ed8ba2

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.