Opened on 01/15/2015 at 05:58:41 PM

Closed on 01/22/2015 at 07:44:38 PM

#1819 closed change (fixed)

Update dependency on adblockplusui in adblockpluschrome and remove unnecessary code

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-1.8.11-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/4918989293617152/

Description

Background

This change will import #1814 and allow some cleanup.

What to change

In addition to removing the dependency, the global openOptions() function can be removed.

Hints for testers

The link to disable acceptable ads on the first-run page should still work after this change.

Attachments (0)

Change History (3)

comment:1 Changed on 01/15/2015 at 06:03:21 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/22/2015 at 12:33:30 PM by trev

  • Summary changed from Update dependency on adblockplusui in adblockpluschrome to Update dependency on adblockplusui in adblockpluschrome and remove unnecessary code

comment:3 Changed on 01/22/2015 at 07:44:38 PM by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockpluschrome/rev/2d5733d3f58c

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.