Opened on 01/30/2015 at 10:00:59 AM

Closed on 02/13/2015 at 02:22:31 PM

#1909 closed change (fixed)

Update IE detection that uses new "Edge" Rendering engine

Reported by: saroyanm Assignee: fhd
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: fhd, till, oleksandr Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/6566444930170880/

Description

Background

Microsoft developing new browser called Spartan which has new rendering engine (Edge), but it also has different User Agent which we are not detecting now when user enters adblockplus.org.

What to change

Update server side IE detection and anwiki infrastructure to also detect Spartan browser and IE browsers in Edge mode.

Notes

User agent for Internet Explorer for Windows 10 in Edge mode:
Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36 Edge/12.0

Attachments (0)

Change History (4)

comment:1 Changed on 01/30/2015 at 10:11:16 AM by saroyanm

@fhd I have doubt that current serverside implementation of IE detection is not consistent with the one we have in anwiki repo:

\bMSIE\ \d+

Because it doesn't match most of IE 11 user agents while we still detecting them:

Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko

Would it be possible to have both implementations in sync ?
Or maybe I should consider this ticket as the infrastructure one ?

comment:2 Changed on 02/13/2015 at 02:19:36 PM by fhd

  • Component changed from Websites to Infrastructure
  • Owner set to fhd
  • Ready set

comment:3 Changed on 02/13/2015 at 02:22:19 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 02/13/2015 at 02:22:31 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
 
Note: See TracTickets for help on using tickets.