Opened on 02/10/2015 at 02:47:29 PM

Closed on 06/01/2015 at 09:22:03 AM

Last modified on 06/01/2015 at 09:22:38 AM

#1984 closed change (fixed)

Do not use VBScript in installer build tools

Reported by: oleksandr Assignee: oleksandr
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.5
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug installer
Cc: oleksandr Blocked By:
Blocking: #1184 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4565805475823616/

Description

Background

We currently use installer\emb.vbs to embed transforms when building the installer. It is written in VBScript, and we usually use Python for tasks like this.

What to change

Rewrite emb.vbs in Python.

Attachments (0)

Change History (6)

comment:1 Changed on 02/13/2015 at 10:21:38 AM by greiner

  • Keywords goodfirstbug added; goodfrstbug removed

comment:2 Changed on 02/17/2015 at 11:44:25 PM by oleksandr

  • Blocking 1184 added
  • Keywords installer added

comment:3 Changed on 04/13/2015 at 10:41:41 PM by oleksandr

  • Owner set to oleksandr
  • Review URL(s) modified (diff)
  • Verified working unset

comment:4 Changed on 04/13/2015 at 10:41:52 PM by oleksandr

  • Status changed from new to reviewing

comment:5 Changed on 06/01/2015 at 09:22:03 AM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 06/01/2015 at 09:22:38 AM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.5

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from oleksandr.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.