Opened on 02/11/2015 at 11:50:58 AM
Closed on 02/11/2015 at 04:39:07 PM
Last modified on 02/11/2015 at 05:04:37 PM
#1985 closed change (fixed)
Replace __proto__ with Object.create() and Object.getPrototypeOf()
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | goodfirstbug |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Background
The __proto__ property isn't officially supported before ES6. Also using it impairs the performance. Therefore we already replaced the __proto__ with Object.create() in the core code and Firefox extension (#656). However, a lot of code for Chrome, Opera and Safari is still using __proto__.
What to change
Use Object.create() and Object.getPrototypeOf() instead the __proto__ property.
Hints for tester
Well, this change effect pretty much all of our code. ;)
Attachments (0)
Change History (3)
comment:1 Changed on 02/11/2015 at 11:52:10 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 02/11/2015 at 04:39:07 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 02/11/2015 at 05:04:37 PM by sebastian
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/cdd2edad1457