Opened on 03/24/2014 at 07:28:42 AM

Closed on 03/24/2014 at 01:09:18 PM

#199 closed change (fixed)

[filter lists] Don't allow multiple Expires comments

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: arthur Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6282217760227328

Description

Background

Currently, the combined filter lists keep the Expires comments from all included filter lists. However, Adblock Plus will only respect the last one, with the result that various EasyList combinations get the expiration time of EasyList (which is being included last).

What to change

Remove all but the first Expires comment.

Attachments (0)

Change History (2)

comment:1 Changed on 03/24/2014 at 07:52:44 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/24/2014 at 01:09:18 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/sitescripts/rev/0992acd16cdc

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.