Opened on 02/26/2015 at 07:23:54 PM

Closed on 02/27/2015 at 04:26:45 PM

#2053 closed change (fixed)

Replace Adblock Plus logo on the first-run page

Reported by: trev Assignee: trev
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner, sven Blocked By:
Blocking: #1533 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5767210236641280/

Description

Background

Subject of #1533 is replacing the ABP logo by the new one everywhere. So far, this didn't happen for the first-run page however, it still uses an old 100x99 image (custom size).

What to change

Use the 128x128 ABP logo (icons/abp-128.png in the adblockpluschrome repository), it's closest in size to the old one.

Attachments (2)

old.png​ (87.7 KB) - added by trev on 02/26/2015 at 07:31:37 PM.
new.png​ (86.0 KB) - added by trev on 02/26/2015 at 07:31:45 PM.

Download all attachments as: .zip

Change History (6)

comment:1 Changed on 02/26/2015 at 07:26:57 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Changed on 02/26/2015 at 07:31:37 PM by trev

Changed on 02/26/2015 at 07:31:45 PM by trev

comment:2 Changed on 02/26/2015 at 07:35:37 PM by trev

  • Cc sven added

Here is what it looks like with the current changes:

Old New

The content has been moved down by a bunch of pixels due to the larger logo.

comment:3 Changed on 02/27/2015 at 01:33:59 PM by sven

lgtm

comment:4 Changed on 02/27/2015 at 04:26:45 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplusui/rev/d1335219a5ac

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.