Opened on 02/28/2015 at 09:37:37 AM
Closed on 03/03/2015 at 08:28:31 AM
#2063 closed change (fixed)
Make ext.webRequest use ABP instead Chrome request types
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2064 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Background
Currently, ext.webRequest.onBeforeRequest uses Chrome's request types. However, in webrequest.js we convert them into into Adblock Plus request types. This could be simplified if we map elements directly to Adblock Plus requests tyes on Safari, and just convert the requests type in the implementation for Chrome.
What to change
Make ext.webRequest.onBeforeRequest use Adblock Plus request types (e.g. SUBDOCUMENT instead sub_frame and IMAGE instead image).
Hints for testers
This change effects request blocking, in particular filters limited to a given request type.
Attachments (0)
Change History (3)
comment:1 Changed on 02/28/2015 at 09:52:29 AM by sebastian
- Blocking 2064 added
comment:2 Changed on 02/28/2015 at 09:55:23 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 03/03/2015 at 08:28:31 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/a995e650f776