Opened on 02/28/2015 at 09:52:29 AM
Closed on 03/03/2015 at 08:30:49 AM
#2064 closed change (fixed)
Configure indistinguishable request types in the abstraction layer
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | #2063 | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Background
Some request types can't be distinguished on Chrome and Safari. However, those are not the same request types. So instead of hard-coding the indistinguishable request types in background.js, those should be provided by the abstraction layer.
What to change
Make indistinguishable request types configured with the new property ext.webRequest.indistinguishableTypes. Consider that property when mapping indistinguishable types.
Hints for testers
This change effects request blocking, in particular filters limited to a given request type. Also make sure that OBJECT, MEDIA and OTHER are correctly distinguished on Safari now.
Attachments (0)
Change History (2)
comment:1 Changed on 02/28/2015 at 09:56:20 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/03/2015 at 08:30:49 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/d607be97dec5