Opened on 03/03/2015 at 03:42:25 PM
Closed on 03/04/2015 at 11:39:31 AM
Last modified on 03/04/2015 at 02:15:35 PM
#2080 closed change (fixed)
Remove duplicated code from clickHide_deactivate
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description
Background
In order to fix #1610, we added an argument to clickHide_deactivate() to keep the overlays but removing the event listeners, when showing the "Block element" dialog. However, this is what clickHide_rulesPending() already does. But for some reason that function isn't used anymore.
What to change
Call clickHide_rulesPending() instead clickHide_deactivate(true) when showing the "Block Element" dialog. And remove the keepOverlays argument from clickHide_deactivate(). Also remove duplicated code from clickHide_deactivate(), calling clickHide_rulesPending() there instead.
Hints for testers
Make sure that "Block element" works as it did before, especially in the case when the dialog showed up, and you move the mouse across the page.
Attachments (0)
Change History (3)
comment:1 Changed on 03/03/2015 at 03:43:25 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/04/2015 at 11:39:31 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/adblockpluschrome/rev/55547504af3b