Opened on 03/06/2015 at 02:36:13 PM
Closed on 03/27/2015 at 01:17:36 PM
#2100 closed defect (fixed)
"Block element" dialog moves out of visible area when attempt to drag it
| Reported by: | passbrains | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.9-for-Chrome-Opera-Safari |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by greiner)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ASA-44
Environment
Chrome, Opera and Safari
How to reproduce
- Go to any page, where "Block Element" is supported (i.e: HTTP(S) protocol + HTML content + not whitelisted)
- Click ABP button on toolbar
- Click "Block element" option
- Click any element on the page
- Drag the dialog out of the visible area
Observed behaviour
Add filter window disappears, it moves out of screen when attempt to drag it.
Expected behaviour
It shouldn't be possible to drag the "Block element" dialog out of the visible area.
What to change
In include.postload.js prevent frame from moving outside the viewport by checking the coordinates sent by the frame against window.innerWidth and window.innerHeight.
Attachments (3)
Change History (8)
Changed on 03/06/2015 at 02:36:16 PM by passbrains
Changed on 03/06/2015 at 02:36:17 PM by passbrains
Changed on 03/06/2015 at 02:36:18 PM by passbrains
comment:1 Changed on 03/06/2015 at 02:44:36 PM by sebastian
- Cc sebastian greiner added
- Component changed from Unknown to User-Interface
- Description modified (diff)
- Owner set to greiner
- Platform changed from Safari to Unknown
comment:2 Changed on 03/06/2015 at 02:45:16 PM by sebastian
- Summary changed from Add filter window moves out of screen when attempt to drag it to "Block element" dialog moves out of visible area when attempt to drag it
comment:3 Changed on 03/06/2015 at 06:43:09 PM by greiner
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:4 Changed on 03/09/2015 at 04:39:02 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 03/27/2015 at 01:17:36 PM by greiner
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
- Verified working unset
Note: See
TracTickets for help on using
tickets.
Reproduced. Putting greiner in CC for further triaging.