Opened on 03/06/2015 at 06:18:04 PM
Closed on 03/09/2015 at 12:25:56 PM
Last modified on 05/12/2015 at 01:53:08 PM
#2101 closed change (fixed)
[adblockplus.org Anwiki to CMS migration] Don't duplicate generic interface strings for each interface
| Reported by: | trev | Assignee: | kzar |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Background
Current implementation will add generic messages like "General notes" to the locale file for each interface. This is unnecessary duplication.
What to change
Move these strings into a shared locale file, e.g. interface.json.
Attachments (0)
Change History (4)
comment:1 Changed on 03/08/2015 at 03:16:44 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/08/2015 at 03:16:58 PM by kzar
- Owner set to kzar
comment:3 Changed on 03/09/2015 at 12:25:56 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/12/2015 at 01:53:08 PM by Ross
- Verified working set
Interface strings are no longer duplicated.
Tested by:
Running the convert script and checking the output. Output contains one version of the interface strings which are then referred to elsewhere with {{sX StringName }} as expected.
Note: See
TracTickets for help on using
tickets.
Fixed:
https://hg.adblockplus.org/wwwnew/rev/8c19fda625dc
https://hg.adblockplus.org/wwwnew/rev/12d99f2d1c06