Opened on 03/10/2015 at 08:12:45 AM
Closed on 03/27/2015 at 03:53:04 PM
Last modified on 05/14/2015 at 10:32:57 AM
#2112 closed change (fixed)
[CMS] Support inserting fixed text into strings
| Reported by: | trev | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | saroyanm | Blocked By: | |
| Blocking: | #2035, #2339 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description (last modified by kzar)
Background
Currently there is an occasional patterns like {{s123 There are more than}} 20 {{s124 million users}} in our pages. The two strings s123 and s124 should really be one string but the number 20 is fixed and preventing these strings from being merged.
What to change
Support inserting fixed strings into a localizable string, e.g. as {{s123 There are more than <fix>20</fix> million users}}. The actual string to be translated should be There are more than {1} million users. - insertion points for fixed strings should be indicated by placeholders {1} and {2}.
Attachments (0)
Change History (11)
comment:1 Changed on 03/10/2015 at 08:13:35 AM by trev
- Blocking 2035 added
- Cc 2035 removed
comment:2 Changed on 03/10/2015 at 02:09:55 PM by saroyanm
- Cc saroyanm added
comment:5 Changed on 03/25/2015 at 02:46:17 PM by kzar
- Owner set to kzar
- Verified working unset
comment:6 Changed on 03/26/2015 at 04:55:12 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 03/27/2015 at 03:53:04 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 04/17/2015 at 02:14:05 PM by trev
- Blocking 2339 added
comment:10 Changed on 05/07/2015 at 11:48:05 AM by kzar
comment:11 Changed on 05/14/2015 at 10:32:57 AM by Ross
- Verified working set
Implemented and working.
Tested by:
Checking data in web.adblockplus.org (index.tmpl/json has a good example). Also running the website converter script as per the read me and checking the output.
Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387
https://hg.adblockplus.org/cms/rev/2e94ab5237b8