Opened on 04/17/2015 at 02:14:05 PM
Closed on 05/04/2015 at 11:49:11 AM
Last modified on 05/14/2015 at 08:58:54 PM
#2339 closed change (fixed)
Don't let fixed strings break up translations
| Reported by: | trev | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Unknown | Keywords: | 2015q2 |
| Cc: | kzar | Blocked By: | #2112 |
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Background
We currently have the following code in our index.tmpl:
<h1>{{"Over"|translate("s46")}} 300 {{"million downloads"|translate("s47")}}</h1>
This is one sentence broken up into two translation, which isn't optimal.
What to change
Adjust the conversion script to use the syntax introduced in #2112:
<h1>{{"Over <fix>300</fix> million downloads"|translate("s46")}}</h1>
Attachments (0)
Change History (6)
comment:1 Changed on 04/21/2015 at 09:12:36 AM by fhd
- Keywords 2015q2 added
comment:2 Changed on 04/25/2015 at 03:09:00 PM by kzar
- Owner set to kzar
comment:3 Changed on 04/29/2015 at 03:03:04 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 05/04/2015 at 11:49:11 AM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/14/2015 at 08:58:54 PM by Ross
- Verified working set
Fixed.
Tested by:
Checking HTML source on beta.adblockplus.org and checking for <fix> in translatable strings after running the conversion script.
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387
Note: See
TracTickets for help on using
tickets.
Fixed as part of https://hg.adblockplus.org/web.adblockplus.org/rev/0f137601cc82.