Opened on 03/10/2015 at 02:36:48 PM
Closed on 03/10/2015 at 05:35:08 PM
#2115 closed defect (fixed)
'Block element' is not issuing Add filters dialog box.
| Reported by: | passbrains | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | mapx, sebastian | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by Ross)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-146
Environment
Windows + 8 64bit + Chrome + English
ABP version 1.8.11.1391
How to reproduce
- Open http://www.amazon.in/.
- Right-click on cart on top most right corner and choose 'Block element'.
Observed behaviour
Add filters dialog box is not opened.
Expected behaviour
Add filters dialog box is opened with suggested filters.
Related to #1868.
Attachments (1)
Change History (9)
Changed on 03/10/2015 at 02:36:56 PM by passbrains
comment:1 Changed on 03/10/2015 at 02:37:01 PM by passbrains
comment:3 Changed on 03/10/2015 at 03:49:41 PM by mapx
error in console
Error in event handler for runtime.onMessage: TypeError: Cannot read property 'getAttribute' of null
at getBlockableElementOrAncestor (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.postload.js:398:27)
at chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.postload.js:682:60
at Object.EventTarget._dispatch (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/ext/common.js:51:41)
at chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/ext/content.js:3:24
comment:4 Changed on 03/10/2015 at 03:51:38 PM by mapx
- Cc mapx added
- Component changed from Unknown to Platform
comment:5 Changed on 03/10/2015 at 03:52:07 PM by mapx
- Cc sebastian added
comment:6 Changed on 03/10/2015 at 05:30:04 PM by sebastian
- Owner set to sebastian
- Priority changed from Unknown to P2
- Ready set
Ouch, this regression were introduced with #1282. It happens every time we encounter an image map aka <area> tag. It's just a silly typo in the code, where image is supposed to be images[i] resulting into that error.
comment:7 Changed on 03/10/2015 at 05:31:22 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 03/10/2015 at 05:35:08 PM by sebastian
- Milestone set to Adblock-Plus-1.8.12-for-Chrome-Opera-Safari
- Resolution set to fixed
- Status changed from reviewing to closed
1 - 10 Mar 2015 14:36:17 posted by Ross Green
Reproduced on Chrome 40 x64 / Windows 8 x64 with Chrome build 1.8.11.1391.